Repository navigation
Installer: Start menu shortcut with the exe's icon, so a taskbar pin keeps it after an update - #58
Merged
Merged
Conversation
|
Pull requests start as drafts here. Mark this one Ready for review when it's done and all checks have passed. |
…keeps it after an update
The shortcut was advertised with an icon from the MSI's Icon table, which Windows keeps in
C:\Windows\Installer\{ProductCode}. Every version is a major upgrade with a new product code, so the
upgrade removed that folder and a copy pinned to the taskbar showed a blank page. The shortcut is now
a plain one to C:\Program Files\RemoteHub\RemoteHub.exe and takes the exe's icon; it has its own
component with an HKCU KeyPath (ICE43/ICE57).
Tests: InstallerTests (unit), C-MSI-01 and C-MSI-04 check the shortcut's target and that its icon
file exists after install and after an upgrade.
GrischaE1
force-pushed
the
taskbar-icon
branch
from
October 20, 2026 17:13
3d4860f to
b1c1b4f
Compare
GrischaE1
marked this pull request as ready for review
October 20, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: RemoteHub pinned to the taskbar shows a blank page instead of its icon after an update.
Cause: the Start menu shortcut was advertised, with an icon from the MSI's Icon table. Windows keeps that icon in
C:\Windows\Installer\{ProductCode}\AppIcon.ico. Every version is a major upgrade with a new product code, so the upgrade removes the old folder. A pinned copy of the shortcut still points there, so its icon disappears.Fix: the shortcut is now a plain one to
C:\Program Files\RemoteHub\RemoteHub.exe, with no Icon of its own, so Windows shows the exe's icon. That path doesn't change across upgrades. The shortcut has its own component with an HKCU registry value as KeyPath, which ICE43/ICE57 require for a non-advertised shortcut. Existing pins from older versions still point at a removed folder, so What's new for 0.21.0 asks users to unpin and pin RemoteHub again once.Tests
InstallerTestschecks inPackage.wxsthat the shortcut isn't advertised, has no Icon, and targets the exe.