Repository navigation
Agent desktop: frame rate adapts to a slow network; files dropped on the tab are saved on the device - #69
Merged
Conversation
… on the tab are saved on the device's Desktop Frame rate (agent-desktop-draft.md 4.4): - When the acks come late (a quarter of a 2 s window spent waiting), one step every 2 s: the quality by 10 to 50, then the frame rate by a third to 5 fps, then the quality by 10 to 20 - text stays readable before the picture moves less often. Back up in the reverse order when the acks keep up. The encoder keeps the asked rate, so no key frame per step. Stats carry frameRateLimit; RemoteHub's connection info says when the rate is lowered. Drag and drop (4.7): - Files and folders dragged onto the tab go as transfer kind "drop" (feature dropFiles): sent at once, never offered, saved in the signed-in user's Desktop\From RemoteHub - or a dated folder in it when a name is taken. Same right as copying files (DesktopClipboard 3), closed at the lock screen like the clipboard. The helper writes as the user, so a junction they plant leads only where they may write. An unfinished drop removes only what it created (TransferReceiver ownsFolder: false) - before, a failed transfer deleted its whole folder. The device never sends a drop; an offer of one is refused. Receipt names the folder; new audit event 1108 (counts, size, folder - no file names). While dragging, the tab says where the files go or why they can't. Tests: unit tests for the steps, the info line, drops end to end (saved, dated folder, refused offer, policy, unfinished drop, folder choice, texts and drag state). Lab: harness step dropFiles, D-VID-14 and D-DROP-01..04 - passed on Server 2025 and W11 (runs 20261023-152043, 20261023-153302). Also a flaky JumpHostTests read of the diagnostic log while it is written. Docs: agent-desktop-draft.md (4.4, 4.7, audit table, open list - stale items removed), README, lab case sheet and test document.
|
Pull requests start as drafts here. Mark this one Ready for review when it's done and all checks have passed. |
…_locks_the_session_before_the_cover_ends AutoSignInSessions ends the cover, then forgets the record; the test checked the record at once and CI (PR #69) looked in between.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two items from the agent desktop's open list (
docs/agent-desktop-draft.md§7): the frame rate now adapts to a slow network, and files can be dropped on the tab.Frame rate on a slow network
Until now only the quality adapted. When the acks come late (a quarter of a 2 s window spent waiting), the device now takes one step every 2 s:
When the acks keep up, it goes back up in the reverse order. The encoder keeps the frame rate that was asked for, so a step doesn't force a key frame.
StatscarryframeRateLimit, and RemoteHub's connection info says "Slow network: the device sends at most N fps to keep the picture sharp."The existing slow-link case D-VID-05 (quality drops below 80) still holds.
Drag and drop onto the tab
Files and folders dragged onto the agent desktop tab are saved on the device's Desktop, in From RemoteHub. When a dropped name already exists there, they go into a dated folder inside it, so nothing is overwritten.
drop, behind the featuredropFiles. It is sent right away and never offered for pasting. The device never sends one, and an offer of one is refused.DesktopClipboard3). Like the clipboard, it is closed while the lock screen is up. The service and the helper both check.TransferReceiverwithownsFolder: false). Until now, a failed transfer deleted its whole target folder, which here would have taken earlier files with it.DesktopFilesSaved, records the count, size and folder, but no file names.Tests
dropFiles, and new cases D-VID-14 and D-DROP-01 to 04 (drop, same names, planted junction, policy).JumpHostTestsread the diagnostic log while other tests were writing to it and failed now and then. It now reads with sharing allowed.JumpHostTeststest, andHelperClipboardFilesTests.A_reader_that_fails_or_hangs…, a timing test this PR doesn't touch, which most likely failed because the machine was busy with the lab.Docs
agent-desktop-draft.md: §4.4, §4.7, the audit table, and the open list. I removed the items in it that are already done: ADMX templates,AllowAgentDesktop, the resume issue.