Skip to content

Lab fixes from the full run of 25 October: person server, RDP restart, marker, consent timing, two stale checks - #74

Merged
GrischaE1 merged 4 commits into
mainfrom
lab-green
Oct 25, 2026
Merged

GrischaE1 merged 4 commits into
mainfrom
lab-green

Conversation

@GrischaE1

Copy link
Copy Markdown
Owner

Fixes for the lab failures of full run 20261025-052539 and the rerun of its failed cases (20261025-132336). All are in the lab; the diagnosis found no product bug behind them.

  • Person server (RhPerson serve): its loop wrote alive.txt and listed request files unguarded. When that met the host's read of alive.txt or a request file vanished, the script's trap ended the server, and later steps got no answer (C-FAV, UI-RDP setup, C-DB-11). Both now wait for the next pass.
  • Remote Desktop Services restart (Restart-LabRdpService): a TermService stop that failed quietly counted as a restart because the old instance still listened on 3389. After UI-RDP's "Always prompt" context the device then asked for the password in every later session, so the clipboard, export, network and jump cases had no session (UI-CP-09/10/11, A-CLIP-01, R-RDP-05/08/09, UI-NET-02, UI-JUMP-01), and R-RDP-10/11 failed in setup with "stop failed". It now ends TermService's own svchost if needed and is up only with a new process id listening. UI-RDP also signs out the sessions left over.
  • Marker window (Start-LabMarker): started once more when it doesn't show within 60 s in a freshly signed-in session. C-END-13 now records and checks that the marker was up before it counts keys, as C-END-12 does.
  • UI-AGENT consent timing: the tab's optional Connect and the person's start ran past the 30 s consent countdown on Server 2025 (R-AGENT-01). It now uses 90 s there, as D-CLIP does.
  • Stale checks: S-TLS-04 now expects health's instance id (there since 0.21.4) and checks it is 32 random hex digits. D-IN-04 accepts the Run dialog by its buttons when OCR misreads "Open:". Docs updated.

Lab scripts parse in Windows PowerShell 5.1 and stay ASCII-only. A full lab run follows after merge.

…ialog by its buttons

- The agent's health has carried instance (a random id per start) since 0.21.4; S-TLS-04 still listed the fields
  from before and failed in every run since. It now also checks the id is only 32 random hex digits.
- OCR read Run's 'Open:' as 'en:' in runs 20261022-172139 and 20261025-052539; Cancel and Browse... are Run's own.
…he consent 90 s

- Start-LabMarker stops and starts the marker's task once more when its window doesn't show within 60 s (a session
  signed in moments before: task left Ready, 0x00041303, or its PowerShell never started).
- C-END-13 now records and checks that the marker was up before it counts the keys, as C-END-12 does: no marker
  meant 'no key arrived' (runs 20261025-052539, -132336) though the keyboard wasn't blocked.
- UI-AGENT's agent desktop step: the optional Connect (up to 15 s) and the person's start ran past the 30 s consent
  countdown on Server 2025; ConsentTimeoutSeconds = 90 there, as in D-CLIP.
…st file vanishing

RhPerson's serve loop wrote alive.txt with Set-Content and listed requests without a guard; when that met the host's
read of alive.txt ('Stream was not readable', 'being used by another process') or a request file went away while
listed, the script's trap ended the server and later steps got no answer (run 20261025-052539: C-FAV, UI-RDP setup,
C-DB-11). Both now wait for the next pass.
… the password prompt

Restart-LabRdpService took the old instance's listener on 3389 as the restart when stopping TermService failed
quietly; after UI-RDP's 'Always prompt' context the device then asked for the password in every later session and
the clipboard, export, network and jump cases had no session (run 20261025-132336). A stop that fails now throws or
ends TermService's own svchost; it is up only with a new process id listening. UI-RDP also signs out the sessions
left over before reconnecting.
@github-actions
github-actions Bot marked this pull request as draft October 25, 2026 18:19
@github-actions

Copy link
Copy Markdown

Pull requests start as drafts here. Mark this one Ready for review when it's done and all checks have passed.

@GrischaE1
GrischaE1 marked this pull request as ready for review October 25, 2026 18:40
@GrischaE1
GrischaE1 merged commit 50a23e6 into main Oct 25, 2026
14 checks passed
@GrischaE1
GrischaE1 deleted the lab-green branch October 25, 2026 18:41
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant