Repository navigation
RDP tab no longer hangs RemoteHub when closed through a jump host; lab fixes from the runs of 25–26 October - #75
Merged
Merged
Conversation
…; UI-DESKTOP skips images not laid out - RhPerson wrote every answer through one shared '<out>.part'; when the late answer or the crash handler met the action's own write, one took the file away before the other's move (run 20261025-192331, C-DB-11 and C-NOTE-10: 'Cannot move item ... .part does not exist'). Each writer now uses its own name. - UI Automation answers Rect.Empty (infinite X, minus infinite width) for an image that isn't laid out; its 'area' was infinite and beat the tab's picture (UI-AD-01, UI-AD-05, R-AGENT-02: 'Cannot convert value "∞"').
|
Pull requests start as drafts here. Mark this one Ready for review when it's done and all checks have passed. |
… not 1 s, on a busy runner Waiting for the probes would take about 5 s more (two connects of up to 3 s), so 2.5 s still shows the close doesn't wait for them; CI measured 1.54 s on PR #75.
…icture to come with the next - J-14 slept 8 s for a background job to open its jump connection; the job's start and module import took longer (run 20261026-032740: the PowerShell probe got in, 101). It now waits until the jump host logged the connection, which is held for 60 s. - The decoder runs H.264 in low-latency mode, but at the stream's format change one picture may come out only with the next (Server 2025: 29 of 30). SEC-DEC-06 is about the sandbox; it now accepts one fewer.
…ab sees a hung window - RdpSession released the RDP ActiveX from inside its own OnDisconnected event when a tab was closed. Closing a tab through a jump host then hung RemoteHub's UI thread for good (lab UI-JUMP, runs 20261025-052539 and 20261026-032740: the window stopped answering, every later step failed). The close now finishes on the dispatcher once the event has returned. - UI-JUMP-02 checks that the tab is gone and RemoteHub still answers after that close. - RhPerson names programs that don't respond when a lookup finds nothing (a hung window has no name for UI Automation and dropped out of the list), and the hosts' UI step errors show it. - RhPerson's server no longer ends when the request file it took is already gone (UI-AD-07).
…mes reach the evidence UI-AG-04 failed because RemoteHub.exe ended with 0xc00000fd (stack overflow) after the PowerShell tab's wrong password - in runs of 16.10.2026, 20261025-192331 and 20261026-032740 - and the runtime prints the repeating frames only to standard error. Start-LabClient now starts RemoteHub with standard error to a file of its own, and UI-DESKTOP's EnsureClient adds the newest one to its clientGone evidence.
GrischaE1
changed the title
GrischaE1
marked this pull request as ready for review
October 26, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from full run 20261025-192331 (33 failures, down from 85 after #74) and the rerun of its failed files (20261026-032740).
Product
RdpSessionreleased the RDP ActiveX control from inside the control's ownOnDisconnectedevent. When a tab to a device behind a jump host was closed, the UI thread hung for good: the window stopped answering and every later UI-JUMP step failed (runs 20261025-052539 and 20261026-032740). The close now finishes on the dispatcher once the event has returned. UI-JUMP-02 checks that the tab is gone and RemoteHub still answers.Lab
Rect.Empty, whose area counted as infinite) (UI-AD-01/05, R-AGENT-02).Tests
DecoderProcessTests: closing a session while the decoder is probing may take 2.5 s, not 1 s, on a busy runner (1.54 s in this PR's first CI run); waiting for the probes would take about 5 s more.Lab scripts parse in Windows PowerShell 5.1 and stay ASCII-only; RhPerson's C# compiles (
-Do windowsrun locally); the solution builds without warnings.