feat(prefs): add word characters preference - #2332
Conversation
There was a problem hiding this comment.
Did a test to make sure it works, noticed that it doesn't immediately apply, only on next startup. May be unintuitive.
I was going to comment on the change to the comment as well but the shortened version grew on me on the second reading. Not sure why you did the label like that though, there are others with underscores but we have them conventionally at the front not middle.
| <object class="GtkLabel" id="word_chars_label"> | ||
| <property name="visible">True</property> | ||
| <property name="can-focus">False</property> | ||
| <property name="label" translatable="yes">Word _characters:</property> |
There was a problem hiding this comment.
Why the underscore in the middle?
|
Thank you for catching that! I updated |
What
Add a new Preferences field for configuring the
word-charssetting.Why
Issue #2304 points out that users currently have no way to configure the
word-charsvalue from the Preferences window.This also makes the setting easier to manage when using
--save-preferencesand--load-preferences.How
word_chars_entryfield toguake/data/prefs.glade.word-charssetting inguake/prefs.py.releasenotes/notes/word-chars-preference-9fc892802ca01441.yaml.Testing
make style.make check.make test(30 tests passed).word-charssetting.word-charsvalue.Screenshot
The new Word characters preference available in the Compatibility section.
Closes #2304