Feat: Added rippler for AccountListItemSkin by KSSJW · Pull Request #6306 · HMCL-dev/HMCL

KSSJW · 2026-07-04T08:33:29Z

为`AccountListItemSkin`添加了水波纹效果

实况

1.mp4

注

background.setStyle("-fx-background-color: -monet-surface-container-low-transparent-80; -fx-background-radius: 4;");仍然来自原来的card背景样式：

.card {
    -fx-background-color: -monet-surface-container-low-transparent-80;
    -fx-background-radius: 4;
    -fx-padding: 8px;

    -fx-effect: dropshadow(gaussian, rgba(0, 0, 0, 0.26), 10, 0.12, -1, 2);
}

KSSJW · 2026-07-04T08:33:55Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors AccountListItemSkin by replacing the card depth effect with a RipplerContainer and a background Region to support custom styling and ripple effects. The review feedback points out a critical issue where mouse events can bypass the rootRippler because its child elements are transparent and pickOnBounds is false by default. It suggests explicitly setting rootRippler.setPickOnBounds(true) to ensure clicks and ripple effects are properly triggered across the entire item.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

KSSJW · 2026-07-04T08:39:54Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the AccountListItemSkin UI component by wrapping the root pane in a RipplerContainer to introduce ripple effects, replacing the card style and depth manager with a custom background Region, and setting the center HBox to mouse transparent. The review feedback highlights two issues: first, setting the center HBox to mouse transparent breaks the tooltip on the subtitle, so it is recommended to attach the tooltip to root or rootRippler instead; second, removing the depth manager removes the card's shadow effect, so it is suggested to apply the depth manager to the new background region and ensure it is mouse transparent.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

KSSJW · 2026-07-04T08:48:38Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors AccountListItemSkin by wrapping the root BorderPane in a RipplerContainer to add ripple effects, and introducing a styled background region. The review feedback highlights an issue where the tooltip for Authlib Injector accounts fails to trigger because the center container is mouse-transparent and the root's bounds picking is affected by the rippler. To fix this, the reviewer suggests initializing rootRippler at the beginning of the constructor and installing the tooltip directly on it instead of root.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

KSSJW · 2026-07-04T08:56:27Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the account list item UI in HMCL by wrapping the root layout in a RipplerContainer to enable ripple effects, and introducing a separate background Region with rounded corners and depth. The reviewer pointed out a visual issue where the rectangular RipplerContainer's hover and ripple effects will overflow the background's rounded corners, and suggested clipping the container using FXUtils.setOverflowHidden to match the card's border radius.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Glavo · 2026-07-08T14:05:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76569a9557

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

KSSJW · 2026-07-08T17:18:21Z

@codex review

chatgpt-codex-connector · 2026-07-08T17:18:25Z

To use Codex here, create a Codex account and connect to github.

KSSJW · 2026-07-08T17:19:05Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors AccountListItemSkin by wrapping the root BorderPane inside a RipplerContainer to add ripple effects and cursor styling, and introduces a separate Region for the background. The reviewer noted that because AccountListItemSkin inherits from SkinBase without overriding layoutChildren, adding multiple child nodes directly to getChildren() may cause layout and resizing issues. They recommended overriding layoutChildren or wrapping the nodes in a layout container like StackPane.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

KSSJW · 2026-07-09T04:00:55Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the AccountListItemSkin by wrapping the root layout in a RipplerContainer (rootRippler) to support ripple effects, and moves click handling and tooltips to this container. It also introduces a background Region for styling. The reviewer identified an issue where applying the shadow depth to the nested background region causes the shadow to be clipped by the parent rootRippler due to overflow hiding, and suggested applying the depth effect directly to rootRippler instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

KSSJW

Reviewed

Feat: Added rippler for AccountListItemSkin

433082d

gemini-code-assist Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java Outdated

Refactor: PickOnBounds

246b29b

gemini-code-assist Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java

Fix: Tooltip, background

eed477a

gemini-code-assist Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java Outdated

Fix: Tooltip

5f20c14

gemini-code-assist Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java

Fix: OverflowHidden for rippler

76569a9

KSSJW marked this pull request as ready for review July 4, 2026 09:07

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java

Fix: Allow ripple to receive mouse events

9e216c9

gemini-code-assist Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java Outdated

Refactor: Optimize background layout hierarchy in AccountListItemSkin

6d5a115

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItemSkin.java

Fix: Depth effect

1510661

KSSJW commented Jul 9, 2026

View reviewed changes

Uh oh!

Conversation

KSSJW commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

为AccountListItemSkin添加了水波纹效果

实况

注

Uh oh!

KSSJW commented Jul 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

KSSJW commented Jul 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

KSSJW commented Jul 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KSSJW commented Jul 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Glavo commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

KSSJW commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

KSSJW commented Jul 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

KSSJW commented Jul 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

KSSJW left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KSSJW commented Jul 4, 2026 •

edited

Loading

为`AccountListItemSkin`添加了水波纹效果