Skip to content

chore(tui): name windows::core::BOOL and drop the direct windows-core dependency #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hmbown merged 1 commit into from
Sep 21, 2026
Merged

chore(tui): name windows::core::BOOL and drop the direct windows-core dependency #6390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions crates/tui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,3 @@ objc2-foundation = { version = "0.3.2", default-features = false, features = ["s

[target.'cfg(target_os = "windows")'.dependencies]
windows = { version = "0.62", features = ["Win32_Foundation", "Win32_Media_Audio", "Win32_Security", "Win32_Security_Authorization", "Win32_Storage_FileSystem", "Win32_System_Console", "Win32_System_Diagnostics_Debug", "Win32_System_Diagnostics_ToolHelp", "Win32_System_Environment", "Win32_System_JobObjects", "Win32_System_Registry", "Win32_System_Threading", "Win32_UI_WindowsAndMessaging"] }
# `windows` re-exports most of windows-core's types but not all of them
# (BOOL, HRESULT, … live in windows-core itself); window_control.rs names
# windows_core::BOOL for the EnumWindows callback, so it must be a direct
# dependency. Version already resolved via `windows` — no extra build work.
windows-core = { version = "0.62" }
2 changes: 1 addition & 1 deletion crates/tui/src/tui/window_control.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ mod imp {
SW_RESTORE, SWP_ASYNCWINDOWPOS, SWP_NOACTIVATE, SWP_NOMOVE, SWP_NOSIZE, SWP_SHOWWINDOW,
SetWindowPos, ShowWindowAsync, WINDOWINFO, WS_EX_TOPMOST, WS_MAXIMIZE,
};
use windows_core::BOOL;
use windows::core::BOOL;

/// Pin state: remembers the pre-pin window rect so unpinning restores it,
/// plus whether the window was maximized (unpin restores maximized then,
Expand Down
Loading