Repository navigation
Check release signatures with cosign v2 as well - #142
Merged
Merged
Conversation
The release's signatures are Sigstore bundles in the format cosign v3 reads by default. cosign v2 reads them from 2.4 on only with --new-bundle-format, so install.sh with cosign v2 refused a genuine release as not verifying. install.sh now reads the cosign version: it adds --new-bundle-format for v2.4 and newer, and stops with the version it needs for anything older. The README and docs/verifying-releases.md say which versions work and what to add with v2. CI installs the latest release with cosign v2.4 too, and checks that v2.2 is refused with that message. Refs #141 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
This was referenced Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release's signatures are Sigstore bundles in the format cosign v3 reads by default. cosign v2 reads them from 2.4 on only with
--new-bundle-format. Soinstall.shwith cosign v2 refused a genuine release ("the Sigstore signature does not verify: do not use this file"), and the documentedcosign verify-blobcommands failed with v2.install.shreadscosign version. It adds--new-bundle-formatfor v2.4 and newer, and for anything older it stops with "install cosign v3 (or v2.4 or newer)". With v3 nothing changes.docs/verifying-releases.mdsay which cosign versions work, and what to add with v2.install-script): after the existing install with cosign v3.1.3, it installs the latest release with cosign v2.4.1, and checks that v2.2.4 is refused with the version message and nothing is installed.Tested locally in clean containers against the published v0.4.0: the script installs with v3.1.3 and with v2.4.1, and stops with v2.2.4.
Refs #141