Repository navigation
Run the proxy and TLS inspection test on macOS and Windows - #194
Merged
Merged
Conversation
The proxy-tls workflow becomes a matrix over Linux, macOS and Windows. Each runner uses the native mitmproxy release (pinned by checksum), and the test script puts the proxy's CA in the system store the way an administrator would: security add-trusted-cert on macOS, Import-Certificate on Windows. SSL_CERT_FILE is asserted to have no effect there, as the README states. Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
…indows can open Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #25.
The proxy and TLS inspection test ran on Linux only. It now runs as a matrix on
ubuntu-latest,macos-latestandwindows-latest, with the native mitmproxy 12.2.3 archive for each runner, pinned by SHA-256.update-ca-certificateson Linux,security add-trusted-certinto the System keychain on macOS, andImport-CertificateintoLocalMachine\Rooton Windows.SSL_CERT_FILE) must still work on Linux. On macOS and Windows it must fail like case 1, which checks the README's statement that the variable has no effect there.NO_PROXY) trusts the fake API's CA in the system store on macOS and Windows.Checked locally:
shellcheck,bash -n, actionlint and zizmor. The macOS and Windows jobs run for the first time on this pull request.