Repository navigation
Close the install, verify, uninstall and help gaps found on clean Linux and Windows machines - #202
Merged
Merged
Conversation
Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
…m command BusyBox runs Closes #195 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Closes #196 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Closes #197 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Closes #198 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
…ys and revocation screen Closes #199 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Closes #195 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
… the zip Closes #197 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Closes #200 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Refs #196 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the README step by step on clean debian, ubuntu, fedora and alpine containers and on a clean Windows 11 machine, with release 0.5.0, turned up these gaps.
sha256sumalso runs (grep <archive> SHA256SUMS | sha256sum -c -); on Windows,Get-FileHash, and how to get cosign and Scoop. Closes docs: list what Linux needs to install and verify a release, and a checksum command that works on BusyBox #195.install.shinstalls, and what a Windows uninstall leaves behind. Closes docs: no uninstall steps for the archive and install.sh installs #197.config set --helpnow match the code:login --no-browser, theupdate_checkandtoken_storekeys, and one name for the revocation screen (Account → Applications). Closes docs: README and help disagree with the code on login --no-browser, config set keys and the revocation screen #199.loginandlogoutexit 1, not 3, when the keychain is out of reach, as the exit-code table and the tests already do. Closes docs: login and logout exit 1 where the data commands exit 3 when the keychain is out of reach #200.whoamiwith a user that has an email and no name (refs whoami shows no user for a sign-in: the app does not publish who the user is #182).#201 (the Usage line of a usage error lists
--api-urlwhen the environment sets it) is not addressed here; see the comment there.cargo test -p hodeishield-cli,cargo clippy --all-targets -- -D warningsandcargo fmt --checkpass locally.