Repository navigation
Keep environment values out of --help, and fix the uninstall order - #203
Merged
Merged
Conversation
Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
…check and the Applications screen everywhere Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--helpprinted the values ofHODEISHIELD_API_URLandHODEISHIELD_PROFILE([env: HODEISHIELD_API_URL=https://…]), which end up in terminals and CI logs. Both options keep their environment binding and now show only the variable name (hide_env_values). An integration test sets both variables and an API key, and checks that none of the values appear. No secret is bound through these options; the API key is read separately and was not printed.rm -f "$(hodeishield config path)", so the settings were never removed. The settings now go first, and the usual completion file locations are named.docs/user-information.md(docs: README and help disagree with the code on login --no-browser, config set keys and the revocation screen #199): the revocation screen is Account → Applications, as in the README.Refs #195, #197, #199.