Skip to content

Stop booster packs from dropping when chest blocks are broken #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Howlite-UI merged 1 commit into from
Oct 14, 2026
Merged

Stop booster packs from dropping when chest blocks are broken #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fabric/src/main/java/com/howlite/cobblemoncards/fabric/FabricCobblemonCards.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,9 @@ public MerchantOffer getOffer(Entity entity, RandomSource random) {
private static boolean isChestLootTable(net.minecraft.resources.ResourceLocation location) {
if (location == null) return false;
String path = location.getPath().toLowerCase(java.util.Locale.ROOT);
return path.startsWith("chests/") || path.contains("/chests/") || path.endsWith("_chest") || path.contains("chest");
// Block drop tables (blocks/chest, blocks/trapped_chest, ...) must never match
if (path.startsWith("blocks/")) return false;
// But accept chest loot tables (chests/simple_dungeon, chests/village/village_weaponsmith, mymod:structures/chests/ruins, ...)
return path.startsWith("chests/") || path.contains("/chests/");
}
}
5 changes: 4 additions & 1 deletion neoforge/src/main/java/com/howlite/cobblemoncards/neoforge/NeoForgeCobblemonCards.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,9 @@ public void onAddReloadListeners(AddReloadListenerEvent event) {
private static boolean isChestLootTable(ResourceLocation location) {
if (location == null) return false;
String path = location.getPath().toLowerCase(java.util.Locale.ROOT);
return path.startsWith("chests/") || path.contains("/chests/") || path.endsWith("_chest") || path.contains("chest");
// Block drop tables (blocks/chest, blocks/trapped_chest, ...) must never match
if (path.startsWith("blocks/")) return false;
// But accept chest loot tables (chests/simple_dungeon, chests/village/village_weaponsmith, mymod:structures/chests/ruins, ...)
return path.startsWith("chests/") || path.contains("/chests/");
}
}