Repository navigation
fix(tests): pin walker mobility against pylinkage 1.2.1 - #11
Merged
Merged
Conversation
pylinkage 1.2.1 counts rigid bodies in compute_mobility, so Walker.dof is 1 for every shipped mechanism; test that, and replace the test that pinned the old miscount (a triangle pinned once is 1 DOF, not 3). The dependency floor moves to 1.2.1.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylinkage 1.2.1 (HugoFara/pylinkage#55) makes
compute_mobilitycount rigid bodies, soWalker.dofis finally 1 for Jansen / Chebyshev / Klann / TrotBot / Strider (it was 17 / 5 / 11 / 34 / 41). This pins that with a test, replacestest_triangle_dof_is_three— which documented the old miscount; three bars pinned to the frame at one node are a rigid body with 1 DOF — and raises the floor topylinkage>=1.2.1.CI resolves pylinkage from PyPI; 1.2.1 is published.