Repository navigation
fix(notebooks): fix warnings - #13
Merged
Merged
Conversation
examples/05_topology_co_optimization.ipynb carried two pymoo RuntimeWarnings in its outputs, and a warning names the file that raised it — the absolute path of the venv on the machine that executed it. The warning is expected: a walker that fails scores +inf on purpose, and pymoo's crowding distance then computes inf - inf. Both pymoo calls now run under numpy.errstate(invalid="ignore"); the co_optimize path the notebook uses gets the matching fix from pylinkage (#64). A new test refuses any notebook whose outputs name a home directory.
HugoFara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/05_topology_co_optimization.ipynbstored twoRuntimeWarning: invalid value encountered in subtractfrom pymoo. Root cause: a failed walker scores+infon purpose, and pymoo's crowding distance computesinf - inf.nsga_walking_optimization's parallel path andtopology_walking_optimizationnow run pymoo undernumpy.errstate(invalid="ignore").pylinkage.optimization.co_optimize, whose matching fix is fix(notebooks): illustrate 05 and 12 pylinkage#64; it was re-executed against that branch, so its outputs are clean.tests/test_notebook_outputs.pyrefuses any committed notebook whose outputs name a home directory.Test plan
uv run pytest— 635 passed