Skip to content

feat: bump velocity 4.3.0. - #48

Merged
ksqeib merged 1 commit into
HyperZoneLogin:masterfrom
qyl27:feat/bump-velocity
Oct 25, 2026
Merged

ksqeib merged 1 commit into
HyperZoneLogin:masterfrom
qyl27:feat/bump-velocity

Conversation

@qyl27

@qyl27 qyl27 commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

变更说明

更新Velocity到4.3.0。

关联范围

  • openvc
  • auth-yggd
  • auth-offline
  • data-merge
  • profile-skin
  • api
  • 文档
  • GitHub 工作流 / 仓库配置

变更类型

  • Bug 修复
  • 新功能
  • 重构
  • 文档更新
  • 构建 / CI 调整
  • 其他

测试与验证

请说明你做了哪些验证,例如:

  • 已本地构建通过
  • 已运行相关测试
  • 已验证配置生成 / 加载正常
  • 已验证迁移逻辑或命令行为
  • 已更新相关文档

兼容性与风险

预期无影响。

其他补充

N/A

Summary by Sourcery

Upgrade the project’s Velocity dependency and related backend integration to the 4.3.x line.

Build:

  • Update Velocity dependencies to 4.3.0 and add the Maven repository required to resolve them.

Chores:

  • Update the NanoLimbo backend subplugin reference.

@sourcery-ai

sourcery-ai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

本 PR 将项目及 nanolimbo 后端升级至 Velocity 4.3.1-SNAPSHOT,通过新增 Maven 仓库支持 SNAPSHOT 依赖解析,并同步调整相关子模块版本引用;作者已声明本地构建通过,预期无兼容性影响。

File-Level Changes

Change Details Files
升级 Velocity 依赖及其相关组件版本,并补充用于解析 SNAPSHOT 构件的 Maven 仓库。
  • 将 Velocity 与 Velocity CTE 版本从 4.2.1-SNAPSHOT 更新至 4.3.1-SNAPSHOT。
  • 新增 yuluo.dev 公共 Maven 仓库以支持新版本依赖解析。
  • 同步更新 nanolimbo 后端子模块引用。
build.gradle.kts
gradle/libs.versions.toml
subplugin/backend-nanolimbo

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="build.gradle.kts" line_range="256" />
<code_context>

         maven("https://repo.papermc.io/repository/maven-public/")
         maven("https://maven.fabricmc.net/")
+        maven("https://maven.yuluo.dev/repository/maven-public/")
         maven("https://repo.opencollab.dev/maven-snapshots")
         maven("https://maven.elytrium.net/repo/")
</code_context>
<issue_to_address>
**Repository can inject executable artifacts**

When the required Velocity artifact is not found in the preceding repositories and this repository serves a malicious artifact for its coordinates, gradle resolves dependencies absent from the earlier repositories here without restricting this repository to Velocity coordinates. A compromised repository operator can serve a malicious Velocity proxy artifact, which runs on `vc-runtest`'s runtime classpath when the test server is launched.

Restrict this repository to the Velocity groups it is intended to provide and verify the resolved artifacts with Gradle dependency verification.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: build.gradle.kts:256


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread build.gradle.kts Resolved
@ksqeib

ksqeib commented Oct 25, 2026

Copy link
Copy Markdown
Member

版本不对,参考 https://papermc.io/downloads/velocity 使用里面最新能下载到的

Signed-off-by: 秋雨落 <i@rain.cx>
@qyl27
qyl27 force-pushed the feat/bump-velocity branch from ef0ecc8 to cdb33aa Compare October 25, 2026 09:25
@qyl27 qyl27 changed the title feat: bump velocity 4.3.1-SNAPSHOT. feat: bump velocity 4.3.0. Oct 25, 2026
@ksqeib
ksqeib merged commit 4b158f4 into HyperZoneLogin:master Oct 25, 2026
1 of 2 checks passed
@qyl27
qyl27 deleted the feat/bump-velocity branch October 25, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants