Repository navigation
feat: bump velocity 4.3.0. - #48
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's Guide本 PR 将项目及 nanolimbo 后端升级至 Velocity 4.3.1-SNAPSHOT,通过新增 Maven 仓库支持 SNAPSHOT 依赖解析,并同步调整相关子模块版本引用;作者已声明本地构建通过,预期无兼容性影响。 File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="build.gradle.kts" line_range="256" />
<code_context>
maven("https://repo.papermc.io/repository/maven-public/")
maven("https://maven.fabricmc.net/")
+ maven("https://maven.yuluo.dev/repository/maven-public/")
maven("https://repo.opencollab.dev/maven-snapshots")
maven("https://maven.elytrium.net/repo/")
</code_context>
<issue_to_address>
**Repository can inject executable artifacts**
When the required Velocity artifact is not found in the preceding repositories and this repository serves a malicious artifact for its coordinates, gradle resolves dependencies absent from the earlier repositories here without restricting this repository to Velocity coordinates. A compromised repository operator can serve a malicious Velocity proxy artifact, which runs on `vc-runtest`'s runtime classpath when the test server is launched.
Restrict this repository to the Velocity groups it is intended to provide and verify the resolved artifacts with Gradle dependency verification.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: build.gradle.kts:256
Member
|
版本不对,参考 https://papermc.io/downloads/velocity 使用里面最新能下载到的 |
Signed-off-by: 秋雨落 <i@rain.cx>
qyl27
force-pushed
the
feat/bump-velocity
branch
from
October 25, 2026 09:25
ef0ecc8 to
cdb33aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
更新Velocity到
4.3.0。关联范围
openvcauth-yggdauth-offlinedata-mergeprofile-skinapi变更类型
测试与验证
请说明你做了哪些验证,例如:
兼容性与风险
预期无影响。
其他补充
N/A
Summary by Sourcery
Upgrade the project’s Velocity dependency and related backend integration to the 4.3.x line.
Build:
Chores: