Repository navigation
fix(federation): refuse an empty fragment in Entity Identifiers; update the Trust Chain expiry note - #781
Merged
Conversation
…ource_endpoint isHTTPSURL checked url.URL.Fragment, which url.Parse leaves empty for a bare "#", so "https://ia.example.org#" passed as an authority hint, trust anchor hint or source_endpoint. It now refuses any "#", as the issuer, endpoint and redirect URI parsers do since v0.69.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ires The v0.62.0 section said a flow already begun completes as before. Since v0.69.0 the client refuses every method that contacts or trusts the OP once the chain has expired, with a *client.Error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to the v0.69.0 review fixes.
fix(federation):internal/federation'sisHTTPSURLcheckedurl.URL.Fragment, whichurl.Parseleaves empty for a bare#, sohttps://ia.example.org#was accepted as anauthority_hintsortrust_anchor_hintsentry or asource_endpoint. It now refuses any#, matching the issuer, endpoint and redirect URI parsers. Two cases added toTestParseRefusesStatementsSection32Rejects; both fail before the change.docs(upgrading): the section on a Client stopping at the Trust Chain's expiry said a flow already begun completes as before. Since the client gating fix, every method that contacts or trusts the OP refuses once the chain has expired, with a*client.Error(ErrorTrustChainExpired). The section now says so.🤖 Generated with Claude Code