Repository navigation
test(fapi): expect FuzzParseEndpointURL to refuse an empty fragment - #783
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Since v0.69.0 a URL ending in a bare "#" is refused, but the fuzz oracle still required an otherwise valid loopback http URL to be accepted when url.Parse showed no fragment, and url.Parse drops a bare "#". The nightly run found "http://loCAlhost#". The oracle now treats any "#" in the input as a fragment, both when it may be refused and when an accepted URL must have none. The input is kept as a seed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
osanderson
force-pushed
the
test/fuzz-url-empty-fragment
branch
from
November 2, 2026 08:24
ab9b639 to
79615ac
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fuzz run on main found
http://loCAlhost#inFuzzParseEndpointURL. The parser is right: since the empty-fragment fix, a URL ending in a bare#is refused. The oracle was stale. It required an otherwise valid loopbackhttpURL to be accepted underAllowLoopbackHTTPwheneverurl.Parsereported no fragment, andurl.Parsedrops a bare#.#.#in the input, so the fuzzer enforces the new rule instead of only tolerating it.testdata/fuzz/FuzzParseEndpointURL/.Test-only. A 60 s local fuzz run is clean.
Fixes #782.
🤖 Generated with Claude Code