UI: a few tweaks to fix roundtrip modals as prompt content - #11105
UI: a few tweaks to fix roundtrip modals as prompt content#11105schmitz-ilias wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Hi @schmitz-ilias,
Thx a lot for bringing this to my attention!
That is actually a very unintended side-effect of making the Input\Form\Standard a valid prompt content (good example of why inheritance is bad). Using a Modal\Roundtrip as content for a Prompt\Prompt defeats its purpose, since it was actually meant to replace it =).
So, if you tell me what contents your roundtrip modal holds, besides a Input\Form\Standard and a MessageBox\MessageBox, we can discuss if something else should become a Prompt\IsPromptContent instead.
In the meantime, I will open a PR myself to remove any unwanted derivatives of Input\Form\Standard from being valid prompt content.
Kind regards,
@thibsy (as UI coordinator)
|
See #11853 |
This PR makes roundtrip modals work as the content of prompts. Most of the needed infrastructure is already there from the original implementation of prompts, there are just a few tweaks needed, mostly in rendering.
I'm using prompts in the implementation of ‘Publish as OER‘ Button for Objects, and with these tweaks everything works great. Prompts are a really handy tool for implementing multi-step workflows asynchronously.
Let me know if you want anything done differently.
Cheers, Tim