[A11y] fix: Improve wiki title and language for further pdf print - #11820
[A11y] fix: Improve wiki title and language for further pdf print#11820abrahammordev wants to merge 1 commit into
Conversation
Annett7811
left a comment
There was a problem hiding this comment.
Hello @abrahammordev!
First of all, thank you very much for addressing the issue and coming up with a possible solution. I tested the changes using a sample wiki export in Chrome, Firefox, and Safari. The results vary:
- In Chrome, the checks for primary language, and document title pass.
- In Firefox and Safari, the checks for primary language fail.
These changes therefore lead to a noticeable improvement in the accessibility-related document properties, particularly in Chrome.
Best regards
Annett
|
Hi @Annett7811! Thank you very much for your feedback. We really appreciate it, and I am glad to hear that the behavior has improved when using a chromium setup. However, PDF printing vary depending on the browser and OS, so I am afraid it may not be possible for us to cover every potential scenario. I have requested a review from @thibsy in case he can help us identify a more robust approach to this issue. Best, |
This PR addresses the accessibility issues reported in the following ticket:
https://mantis.ilias.de/view.php?id=33543
The ticket describes several accessibility problems found in the generated results PDF.
After investigating the current implementation, my understanding is that ILIAS generates the HTML structure used for the print view, while the final PDF generation is handled by the browser. As a result, the output may vary depending on the browser, operating system, and PDF generation engine being used.
The changes proposed in this PR focus on stable document properties that ILIAS can control directly, particularly the document language and title. I have tested the resulting PDF with accessibility validation tools, and these changes reduce the number of reported issues.
@Annett7811, would it be possible for you to review these changes from an accessibility perspective?
@thibsy, I would also appreciate your feedback from the UI perspective, particularly regarding the fact that different browsers or operating systems may interpret and export the same HTML structure differently.
From my point of view, it may be reasonable to address this issue incrementally: first improving the general and consistently controllable aspects of the document, and then investigating more specific issues where the browser-dependent PDF generation allows us to do so.
Thanks,
Abraham