Streamline Logging in a bunch of components - #11859
Open
schmitz-ilias wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Logging component was recently refactored and cleaned up as described in Streamline Logging. This PR contains the changes required to properly conclude the implementation of that feature:
default_levelfield in theilias.ini.php. Also for themaster.ini.php. (ping @thibsy, @chfsx, @acgruber)loggingtag is removed from allservice.xmls andmodule.xmls.ilLogger::writeandilLogger::writeLanguageLoghave been removed, and its usages replaced (mostly withilLogger::info). This makes the public interface of the now deprecatedilLoggermatch the newLoggerInterface.ilLog\log. This is still used by a handful of components, most crucially Init\ErrorHandling, but tracking down all usages exactly is tricky. That logger identifies itself now aslegacy_rootin the log, and only uses the default log level.Especially the last two sets of changes should be understood as transitional. In the long run, only the new
LoggerInterfaceshould be used, but the new infrastructure will only be directly available to other components when the Component revision is a bit further along (see #11430). Until then, this is a step in the right direction, and will ease the transition later on.