Repository navigation
fix: four gaps loomster hit in 0.9.0: drift, sql types, apply --json, Postgres TLS (#273) - #274
Merged
Merged
Conversation
…pes.d.ts, apply --json says how to approve a moved plan, Postgres TLS docs (#273)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273
columns[N].*), which it doesn't count as drift.driftFromLifecyclenow readsdeep.unclaimedand reports each whole extra column (a group with its ownname) ascolumn <name>: declared (none), live <type>. A field src/ leaves unset on a declared column (a default) stays unclaimed, as before. Checked on Postgres and ClickHouse (yodel_273, dropped). The declarative claim's drift part adds a column by hand and expects it.yodel newrefreshessql-types.d.ts. After it writes a migration from src/, when the project keeps the file, it runschant sql types --output <that file>and says "Updated src/sql-types.d.ts". A project without the file gets none.planandapplydon't write it, and CI'schant sql types --checkstill catches a stale file. The templates get atypesscript.apply --jsonsays how to approve the plan as it is now. When the plan moves under the lock after its approval, the failed outcome now hasmoved(withnow, the new digest),approveandchantApprove, and the text says the same. When the run is gated but chant printed no approve line,approveis made from the digest, so--jsonalways has it.moved.nowis in the schema.connectPostgres(libpq's meaning ofsslmode), and I've asked the chant session for it. docs/configuration.md now has a Postgres TLS section:uselibpqcompat=true&sslmode=require, orverify-fullwith RDS's CA bundle, and the RDS example uses it.The local gate passes (844 tests). The declarative claim's new drift check hasn't run: it needs a grant (
npm run grant -- declarative).