Skip to content

Better job summary message when no common errors etc.#307

Merged
rerpha merged 5 commits into
masterfrom
tidy_summary
Jul 15, 2026
Merged

Better job summary message when no common errors etc.#307
rerpha merged 5 commits into
masterfrom
tidy_summary

Conversation

@FreddieAkeroyd

@FreddieAkeroyd FreddieAkeroyd commented Jul 13, 2026

Copy link
Copy Markdown
Member

If there are no common errors across jenkins system tests jobs, then the summary for system_tests_common_failures does not have an entry at that level in the console parsing although individual jobs might. This change is to make sure that the summary always has an entry at each {info,error,warning} level, but the entry may say "nothing to report". Hopefully make things clearer at standup seeing there will always be a common summary to see at each level

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Jul 13, 2026
@rerpha

rerpha commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I think we should just use the logging library rather than invent our own.

@FreddieAkeroyd

Copy link
Copy Markdown
Member Author

print_message was left in by accident, it did more that just print at one point and wasn't left doing much now so i just removed it. Were you wishing to replace all uses of print() in the existing file with a call to the logging library instead?

@rerpha

rerpha commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

yes - the levels etc. are defined as constants already, and we dont need to worry about formatting strings etc.

@rerpha
rerpha merged commit 9a1c916 into master Jul 15, 2026
5 checks passed
@rerpha
rerpha deleted the tidy_summary branch July 15, 2026 06:22
@rerpha rerpha removed this from Tasks Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants