Better job summary message when no common errors etc.#307
Merged
Conversation
Contributor
|
I think we should just use the logging library rather than invent our own. |
Member
Author
|
|
Contributor
|
yes - the levels etc. are defined as constants already, and we dont need to worry about formatting strings etc. |
rerpha
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are no common errors across jenkins system tests jobs, then the summary for system_tests_common_failures does not have an entry at that level in the console parsing although individual jobs might. This change is to make sure that the summary always has an entry at each {info,error,warning} level, but the entry may say "nothing to report". Hopefully make things clearer at standup seeing there will always be a common summary to see at each level