Repository navigation
fix(ci): pin gitleaks 8.30.1 so the allowlist applies - #11
Merged
Merged
Conversation
IgnacioLD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gitleaks job failed on main with two false positives (an empty
GLOSSO_R2_ACCESS_KEYindeploy/.env.exampleand a fake key inTtsRedactionTest). Both paths are already allowlisted, but the action installed gitleaks 8.24.3, which does not understand the[[allowlists]]format and ignored it.GITLEAKS_VERSION: 8.30.1in the workflow (same version as local).benchmark/,COMMERCIAL-LICENSING.md, audit docs).Verified locally:
gitleaks git . --config .github/gitleaks.toml-> no leaks found.