Repository navigation
feat(app): add an F-Droid flavor without Google libraries and model import from a file - #14
Merged
Merged
Conversation
…mport from a file - Split :androidApp into `playstore` and `fdroid` product flavors. Credential Manager, its Play services provider and googleid move from :shared to playstoreImplementation; Google sign-in lives in src/playstore and :shared defaults to UnavailableSignIn, so "Change phone" is hidden in fdroid. - fdroid starts with usage statistics off (F-Droid Tracking anti-feature); onboarding says so. - Leave AGP's Play-encrypted dependency block out of APKs. - Import the on-device scoring pack from files picked with the system picker (SAF, no storage permission), installed only when the SHA-256 matches the pinned or the server-published digest. Available in both flavors. - One runtime classpath lock per flavor for the licensing gate. - Fastlane metadata for every app locale, a draft fdroiddata recipe and docs/FDROID.md with the rules that apply. Claude-Session: https://claude.ai/code/session_01FcVpZoyr8VdRLp1QecX1Ng
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prepares the Android app for F-Droid. The rules that apply, with sources, are in
docs/FDROID.md.playstore(today's behaviour) andfdroidin:androidApp.androidx.credentials,credentials-play-services-authandgoogleidmove from:sharedtoplaystoreImplementation.GoogleSignInmoves toandroidApp/src/playstore.accountSignInin:sharedis now a plainvarthat defaults toUnavailableSignIn. Only the playstoreFlavor.install()replaces it, so "Change phone" is hidden in fdroid.dependenciesInfo.includeInApk = false. The Play-encrypted dependency block is flagged byfdroid scanner. AABs keep it.tools/licensing/runtime-classpath-{fdroid,playstore}.txt). Each flavor'spreBuildchecks its own lock. The catalogue covers the union of both, andlicenses.jsonis unchanged.fastlane/metadata/android/{en-US,es-ES,fr-FR,de-DE}: title, short and full description, andchangelogs/2226.txt.metadata/me.shirobyte42.glosso.yml(AntiFeatures:TetheredNet).testDebugUnitTest,lintDebug,installDebug,connectedDebugAndroidTest).Proof
:androidApp:dependencies --configuration fdroidReleaseRuntimeClasspath):com.google.android.gms,com.google.firebase,com.google.android.libraries.identity,com.android.billingclient,com.google.android.play,credentials-play-services.com.googleartifacts areaccompanist-drawablepainterandguava:listenablefuture(both Apache-2.0).fdroid scanner(fdroidserver 2.4.5, refreshed signatures) reports 0 problems.gradle: [fdroid]on the unmodified tree, reports 0 problems. As a control, movinggoogleidto a plainimplementationgives 1. So the recipe needs noprebuildstripping.fdroid readmetaandfdroid lintpass, using fdroiddata'sconfig/.Tests
:engine:jvmTestLC_ALL=en_US.UTF-8 :server:test:androidApp:testFdroidDebugUnitTest:androidApp:testPlaystoreDebugUnitTest:shared:testDebugUnitTest:androidApp:lintFdroidDebug:androidApp:assembleFdroidRelease,:androidApp:assemblePlaystoreDebug:shared:compileKotlinIosSimulatorArm64gitleaks dir . --redactNew tests:
ModelPackImportTest:FdroidFlavorTest:PlaystoreFlavorTest: Google sign-in is still wired.AnalyticsTestcase for the default-off build.UI check on emulator-5558 (1080x2340, density 480), fdroid debug build:
Open decisions for the owner
Binaries+AllowedAPKSigningKeys). This has to be decided before the first F-Droid release.https://claude.ai/code/session_01FcVpZoyr8VdRLp1QecX1Ng
Replaces #13, rebased onto main after #12 was squash-merged (same diff, single commit).
https://claude.ai/code/session_01FcVpZoyr8VdRLp1QecX1Ng