Repository navigation
Conversation
Webzen's item table spells the Destroy set "Destory" and the shield 6/20 "Guardian Shiled", and the player reads both on screen. - ItemName and tools/Item.txt use the right spelling. - The English, Portuguese and Spanish packs get name fixes for the set (8..11/47) through the existing itemNames mechanism; English also fixes 6/20. English and Portuguese layers now carry itemNames. - Tests check every fixed name lands on a record of each shipped pack and leaves no "Destory"/"Shiled" behind. The item and text goldens are updated on purpose (only en and pt text hashes change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webzen's item table spells the Destroy set "Destory" and the shield 6/20 "Guardian Shiled", and the player reads both on screen.
ItemNameandtools/Item.txtuse the right spelling.itemNamesmechanism; English also fixes 6/20. The English and Portuguese layers now carryitemNames.enandpttext hashes change).vitest on
src/i18n,versions/shared/itemsandsrc/controllers/assetspasses (26 files, 140 tests);tscshows only the existinginstall/clierrors.