Repository navigation
Conversation
openmubr
force-pushed
the
pr/divine-staff-glow
branch
from
November 8, 2026 14:43
6cb8da6 to
e3c6993
Compare
Without a skeleton, bone 0 now uses the mesh's own frame (a node created only when that frame is not the identity, and disposed with the sprites). A model with a skeleton, or with its mesh on the root, is unchanged. The test builds a turned one-bone model and checks the glints lie along the shaft; it fails without the change.
openmubr
force-pushed
the
pr/divine-staff-glow
branch
from
November 8, 2026 14:43
e3c6993 to
cea7ae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Divine Staff of Archangel model has a single bone and comes without a skeleton: the bone's rest transform (turned -90/-90 and moved off the root) is stored on the mesh nodes instead. The lights of
BoneTransform[0]were parented to the model root, without that rotation, so the row of ten glints came out sideways and crossed the character.Without a skeleton, bone 0 now uses the mesh's own frame. A node is created for it only when that frame is not the identity, and it is disposed with the sprites. A model with a skeleton, or with its mesh on the root, is unchanged.
Tests: a new case in
weaponSprites.test.tsbuilds a turned one-bone model and checks the glints lie along the shaft (it fails without the change). vitest onsrc/controllers/actorspasses (24 files, 207 tests);tscshows only the existinginstall/clierrors.