Repository navigation
Conversation
OpenMU corrected the swapped requirements of Fire Scream (MUnique/OpenMU 11bde3735): the skill needs 150 energy and 70 leadership, not 70 and 150. The skill table still carried the old energy value, so the client allowed the cast and showed 70 where the server refuses below 150.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenMU corrected the requirements of Fire Scream, which were swapped (MUnique/OpenMU@11bde3735, "correct the swapped fire scream requirements"): the skill needs 150 energy and 70 leadership, not 70 and 150.
versions/shared/skills/skillsDatabase.tsstill has the old energy value for skill 78, so against a server with the fix the client shows 70 and lets a Dark Lord with less than 150 energy try the cast, which the server then refuses.Change
Skill 78 in
skillsDatabase.ts:energy70 → 150, matchingSkillsInitializer.csof the server. The table has no leadership field, so nothing else changes. Fire Scream Strengthener (518) and Mastery (520) were not affected by the server fix and stay as they are.The file header says it is generated; I changed the single value by hand, since I didn't find the generator in the repository. If you regenerate it from the current server, the result for this line should be the same.
Tests
None added (one data value). Not run against a full build; the change was checked against the server data only.
🤖 Generated with Claude Code