Skip to content

Fix Dark Side integer-tile range check, sticky MU Helper target stall, and stuck right pointer - #525

Open
openmubr wants to merge 1 commit into
Ignies:mainfrom
openmubr:fix/dark-side-helper-stall
Open

openmubr wants to merge 1 commit into
Ignies:mainfrom
openmubr:fix/dark-side-helper-stall

Conversation

@openmubr

Copy link
Copy Markdown
Contributor

Summary

  • In SkillCastSystem, avoids the +0.5 float range slack for Dark Side (263/559) and also checks integer-tile Chebyshev distance (Math.max(|~~tx - ~~heroPos.x|, |~~ty - ~~heroPos.z|) <= def.distance) so the client approaches instead of firing from a tile the server rejects (RageSkillAttackAction checks integer Chebyshev distance).
  • In PointerInputSystem, resets pointerPressed and
    ightPointerPressed on window.blur and document.visibilitychange (when hidden) so a missed pointerup on Alt+Tab does not keep world.castRequest pinned.
  • In mu_helper/loop.ts, switches away from a distant sticky currentTarget (>= 3 tiles) to an adjacent monster (<= 2 tiles) if it remains stuck for >= 3 seconds.
  • Adds a unit test in skillCastSystem.test.ts verifying Dark Side's integer-tile boundary approach.

@openmubr
openmubr requested a review from Ignies as a code owner November 14, 2026 20:52
@openmubr
openmubr force-pushed the fix/dark-side-helper-stall branch from b38b721 to 6cfc95e Compare November 15, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant