Repository navigation
Various bug report fixes - #121
Merged
Merged
Conversation
click pops its context before an unexpected exception propagates out of cli(), so get_current_context() in main always returned None and every bug report listed the env and user as "-". Report unexpected errors from a resource registered on the root click context instead, which runs while ctx.obj is still available. click only passes exception info to context resources as of 8.3.0.
The error handler returned normally after printing the traceback, so the process exited 0 whether or not a bug report was sent. Scripts had no way to tell the command failed.
When stdin wasn't a terminal (cron, CI, piped input), the prompt either consumed whatever was piped in as the answer or hit EOF and raised Abort from inside the error handler, printing a second traceback. Skip the prompt in that case and point to the issue tracker instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.