Repository navigation
Upgrade pyparsing to v3.3.3 - #1606
Closed
danlamanna wants to merge 2 commits into
Closed
danlamanna wants to merge 2 commits into
danlamanna wants to merge 2 commits into
Conversation
The OR parse actions replaced toks[0] in place and returned None. With pyparsing 3.3.3, an OR in parentheses inside an AND reached the AND action still wrapped in a ParseResults. The ES parser then put a list inside a bool filter, and the Django parser raised a TypeError.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Superseded by #1607, which skips pyparsing 3.3.3 until the upstream regression is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With pyparsing 3.3.3, an OR in parentheses inside an AND broke both search parsers, for example
diagnosis_1:foobar OR (diagnosis_1:foobaz AND (diagnosis_1:foo* OR age_approx:50)). The ES parser put a list inside abool.filter, and the Django parser raised aTypeError.The OR parse actions changed
toks[0]in place. They now return the result, which works on 3.3.2 and 3.3.3. This also adds a Django parser case with nested parentheses.Split out of #1587.