Repository navigation
Show the engine AMI field only where an AMI is required - #409
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352
Choosing vLLM on a pool that needs no AMI, such as Kubernetes, showed the Engine AMI field marked required. AMIs are only fetched for AWS pools, so it was an empty required dropdown for a value that is never sent.
requiresAmialready decided validation, the payload, and whether the AMI list is fetched. Its test file says it also gates the dropdown render, but the render had moved intoconfigSections.tsxand checked only the engine.VllmConfignow takesamiRequiredfrom the samerequiresAmiresult, so the four can no longer disagree.This applies to every non-AWS pool, not only Kubernetes:
requiresAmialready returned false for Nosana, Akash, worker and on-prem, and the field now follows it. It also stays hidden until an AWS pool is chosen, where before it showed empty because the list cannot load without one.