Repository navigation
Kubernetes engines pull cached models through the mirror when egress is off - #410
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With model egress off, a Kubernetes deploy passed the cache gate but the engine pod was never pointed at the mirror. Only the worker path applied the mirror step. The direct path built the pod from the stored configuration alone, so on an air-gapped cluster the pod would try huggingface.co and never become ready.
The direct path now runs the same mirror step before creating the pod, so a cached model gets
HF_ENDPOINTin the pod's environment.INFERIA_MODEL_MIRROR_BASEmust be an address the pods can reach.Tests cover the Kubernetes case, a connected install, the public providers, no mirror base, an uncached model, and Ollama.
Related: #311