Skip to content

Make airgap_check stage2 able to pass - #411

Merged
Priyanshu-u07 merged 2 commits into
mainfrom
fix/stage2-can-actually-pass
Oct 16, 2026
Merged

Priyanshu-u07 merged 2 commits into
mainfrom
fix/stage2-can-actually-pass

Conversation

@Priyanshu-u07

Copy link
Copy Markdown
Collaborator

Stage 2 of scripts/airgap_check.sh could never pass. It ran vLLM in the foreground, and since the server never exits, the run could only end in failure. It also defaulted to the stage 1 dummy model, which vLLM cannot serve.

Stage 2 now:

  • takes a real model id and stops early if the vLLM image is not already on the host
  • checks that the running app has model egress off
  • starts vLLM detached on the isolated network, with HF_ENDPOINT pointing at the mirror
  • confirms huggingface.co is unreachable from inside the container (a check that could not run is not counted as blocked)
  • waits until vLLM serves, reports how long it took, and fails early if the container exits
  • sends one completion and requires text back
  • prints vLLM's last log lines on any failure; clean removes the container

Verified on a GPU host with Qwen/Qwen2.5-0.5B-Instruct imported: huggingface.co unreachable, vLLM served in 86s through the mirror, completion returned.

Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
@Priyanshu-u07
Priyanshu-u07 merged commit c2acaa0 into main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant