Repository navigation
Close websocket and Upgrade-header auth bypasses - #412
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
Collaborator
Author
|
Verified end to end on a local stack with a real worker:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes several ways to reach internal endpoints, worker shells and log streams without the right auth.
/deployment/wsis no longer exempt. The gateway's relays already send the key; the worker channel keeps its own token check.node:shellpermission. Admins have it, the default member role does not, and in external auth modes it maps to the admin catalog key. The dashboard hides the Shell link and tab without it.Tests cover each change and fail when it is removed. The related auth, websocket and worker suites pass; the gateway suite's remaining failures also fail on main.
Verified on a local stack: the gateway and orchestration checks fail on main (5 of 11 pass) and all pass on this branch, and only the admin role holds
node:shellafter startup. Org scoping against a live worker and the dashboard changes are covered by tests but not yet run live.