Repository navigation
Fix the persisted logs route and scope it to the caller's org - #415
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /deployment/logs/{id}/persistedfailed on every call: it passed a single connection to a repository that acquires from a pool. It also had no org check, so once working it would have returned any deployment's persisted logs.It now uses the app's pool and answers another org's deployment with the same 404 as a missing one, like the other log routes since #414.
Nothing calls this route today; the dashboard reads persisted logs through
/deployment/logs/{id}.Tests cover the owning org, no persisted logs, another org and a missing deployment. Verified on a local stack: 500 on main, 404 on this branch for an unknown deployment.