Repository navigation
Check deployment ownership against the caller's org - #416
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment routes now act only on deployments that belong to the caller's organisation.
orchestration/ownership.py) compares a record's org with the one the gateway forwards. A missing, empty or "None" org owns nothing. Pools stored asowner_type: "user"with the org's id count as the org's; system pools belong to no org.status,update,terminate,startanddeleteanswer 404 for a deployment outside the caller's org, before any work.GET /deploymentslists the caller's org only; theorg_idquery parameter is ignored, and a caller with no org gets an empty list.user-typed are now reachable by their org.Deployments stored without an org are owned by no one and are no longer reachable through the API.
Tests cover each route for another org, an empty org, "None", no org, and the owning org; the cross-org cases fail on main. Verified on a local stack through the gateway.