feat(nvidia): add Argmax provider - #918
Open
voltjia wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Argmaxoperator.float32,float16, andbfloat16input with anint64scalar output.torch.argmax.Motivation
InfiniCore's basic Llama greedy decoding path needs a canonical InfiniOps replacement for the legacy sampling operator when
top_k=1. The existingArgmaxschema is aligned withtorch.argmax(input, dim=None, keepdim=False), but InfiniOps did not have a native NVIDIA provider for the flattened reduction path.Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
The test build used
CMAKE_CUDA_ARCHITECTURES=80on an NVIDIA A100-SXM4-80GB.Test Results on Supported Platforms
f32,f16, andbf16; native and PyTorch implementation slotsInfiniCore / InfiniLM integration
The dependent InfiniCore branch was built against this provider and ran paged-attention TinyLlama inference in
accelerator-dev/nvidia:latest:The run used
top_k=1and preloaded a trap for the legacyinfiniop*C operator API; the process exited successfully without triggering the trap.Benchmark / Performance Impact
N/A. This adds the previously missing native provider; it is not a performance comparison.
Notes for Reviewers
dim=None,keepdim=false, contiguous non-empty input, and up toINT_MAXelements. These constraints cover the basic Llama greedy sampling path; othertorch.argmaxmodes can be implemented separately.