Repository navigation
feat: Consume debug signing plugin - #312
Closed
baillyjamy wants to merge 1 commit into
Closed
baillyjamy wants to merge 1 commit into
baillyjamy wants to merge 1 commit into
Conversation
Contributor
|
This PR/issue depends on:
|
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update the Core submodule pointer so clean checkouts can resolve the plugin.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Core’s shared debug-signing plugin to the Android application.
Changes:
- Applies the debug-signing convention plugin.
- Uses the shared debug keystore from Core PR #856.
File summaries
| File | Summary |
|---|---|
app/build.gradle.kts |
Applies the shared debug-signing plugin, but the pinned Core submodule must be updated to provide the plugin alias. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| plugins { | ||
| alias(core.plugins.android.application) | ||
| alias(core.plugins.infomaniak.android.debug.signing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume debug signing plugin
Depends on Infomaniak/android-core#856