Repository navigation
fix: Inject appCtx in BackupAgent - #318
Merged
Merged
Conversation
LouisCAD
requested review from
tevincent
and
a balanced review from Copilot
September 28, 2026 09:42
LouisCAD
enabled auto-merge
September 28, 2026 09:42
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused lifecycle fix is consistently applied across both product flavors with no identified issues.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures Splitties’ application context is available when Android initializes backup agents outside normal application startup.
Changes:
- Injects
appCtxduring backup-agent context attachment when uninitialized. - Applies the fix to both standard and F-Droid flavors.
| File | Description |
|---|---|
app/src/standard/kotlin/com/infomaniak/auth/backup/AuthenticatorFullBackupAgent.kt |
Initializes appCtx for standard backups. |
app/src/fdroid/kotlin/com/infomaniak/auth/backup/AuthenticatorFullBackupAgent.kt |
Initializes appCtx for F-Droid backups. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tevincent
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.