Repository navigation
chore: Update Core for fake Block Store support - #324
Merged
Merged
Conversation
tevincent
approved these changes
Oct 6, 2026
tevincent
enabled auto-merge
October 6, 2026 11:44
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The integration is coherent and the only finding is a non-blocking stale comment.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds fake Block Store support for debuggable builds while preserving Play Services behavior in production.
Changes:
- Updates the Core submodule with the Block Store abstraction.
- Migrates passkey backup to Core’s Block Store API.
- Passes backup output for fake-store persistence.
| File | Description |
|---|---|
Core |
Advances Core to fake Block Store support. |
BlockStoreBackup.kt |
Uses Core’s Block Store abstraction. |
AuthenticatorFullBackupAgent.kt |
Supplies backup output to Core. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.