fix(contact-card): remove cache prefix from VCard filename - #862
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches the stated behavior and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes shared VCard filenames while preserving their cache location and sanitization.
Changes:
- Generates filenames from sanitized contact names only.
- Adds targeted filename tests and test dependency.
| File | Description |
|---|---|
ContactCardShareExt.kt |
Separates cache directory from filename generation. |
ContactCardShareExtTest.kt |
Tests prefix removal and sanitization. |
build.gradle.kts |
Adds Kotlin/JUnit test support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
FabianDevel
force-pushed
the
fabiandevel-fix-contactcard-vcard-filename
branch
from
September 21, 2026 14:03
3d944d9 to
7947404
Compare
FabianDevel
changed the title
FabianDevel
force-pushed
the
fabiandevel-fix-contactcard-vcard-filename
branch
from
September 21, 2026 14:03
7947404 to
4793685
Compare
solrubado
approved these changes
Sep 21, 2026
FabianDevel
force-pushed
the
fabiandevel-fix-contactcard-vcard-filename
branch
from
September 21, 2026 14:34
50c047e to
d64d6c2
Compare
FabianDevel
enabled auto-merge
September 21, 2026 14:34
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
FabianDevel
force-pushed
the
fabiandevel-fix-contactcard-vcard-filename
branch
from
September 21, 2026 14:39
d64d6c2 to
f8056d2
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attachments_cachedirectory prefix.cacheDir/attachments_cache.A targeted unit test covers both the visible filename and sanitization behavior.
Validation
./gradlew :Ui:Compose:ContactCard:testFdroidDebugUnitTest :Ui:Compose:ContactCard:testStandardDebugUnitTest --stacktrace./gradlew ktlintCheck --stacktracegit diff --check