Conversation
Now, we're passing the Context. We could also use the injectAsAppCtx() extension.
LouisCAD
requested review from
tevincent
and
a balanced review from Copilot
September 28, 2026 09:25
LouisCAD
enabled auto-merge
September 28, 2026 09:25
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Both variants have compilation failures from a missing import and an unchanged object-style restore call.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Replaces global appCtx usage in Block Store backup with an explicitly supplied Context.
Changes:
- Converts
BlockStoreBackupfrom an object to a context-backed class. - Passes
FullBackupAgentas the backup context. - Updates standard and fdroid implementations.
| File | Description |
|---|---|
Auth/src/standard/.../BlockStoreBackup.kt |
Creates the Block Store client from a supplied context. |
Auth/src/main/.../BlockStoreCredentialsBackup.kt |
Passes the backup agent to BlockStoreBackup. |
Auth/src/fdroid/.../BlockStoreBackup.kt |
Aligns the unsupported implementation with the new constructor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| object BlockStoreBackup { | ||
| const val isSupported: Boolean = false | ||
| class BlockStoreBackup(context: Context) { |
| import splitties.init.appCtx | ||
|
|
||
| object BlockStoreBackup { | ||
| class BlockStoreBackup(context: Context) { |
LouisCAD
disabled auto-merge
September 28, 2026 09:44
Contributor
Author
|
We are choosing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, we're passing the Context.
We could also use the injectAsAppCtx() extension.