Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The fdroid variant cannot compile, the public API change breaks consumers, and the test store mishandles replacement and deletion state.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Adds a file-backed Block Store implementation for testing backup and restore flows in debuggable builds.
Changes:
- Abstracts Google Play Services Block Store access.
- Adds debug file-backed storage and backup integration.
- Passes backup output through the credentials backup API.
| File | Description |
|---|---|
Auth/src/standard/kotlin/com/infomaniak/core/auth/backup/BlockStoreTestingImpl.kt |
Implements test storage and backup. |
Auth/src/standard/kotlin/com/infomaniak/core/auth/backup/BlockStorePlayServicesImpl.kt |
Wraps the production Block Store client. |
Auth/src/standard/kotlin/com/infomaniak/core/auth/backup/BlockStoreBackup.kt |
Uses the new abstraction. |
Auth/src/standard/kotlin/com/infomaniak/core/auth/backup/BlockStore.kt |
Defines and selects Block Store implementations. |
Auth/src/main/kotlin/com/infomaniak/core/auth/backup/BlockStoreCredentialsBackup.kt |
Integrates test-data backup. |
Auth/build.gradle.kts |
Adds the Splitties bitflags dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Because Block Store doesn't restore data on Google APIs emulators once the app has been uninstalled or had its data cleared. This should allow testing in debug without going through the tedious process of: 1. Preparing the app for a release 2. Publishing the release 3. Installing it on the target test device 4. Setting up the app (horrible passwords to type) 5. Triggering the backup 6. Waiting for it to complete (minutes) 7. Resetting the device 8. Waiting for it to complete (minutes) 9. Setting up the device (horrible passwords to type) 10. Waiting for each step to complete (minutes) 11. Waiting for the apps to get reinstalled by the Play Store 12. Hoping you don't have to restart at step 1 because it didn't work and the app is not debuggable
LouisCAD
force-pushed
the
fake-block-store
branch
from
October 1, 2026 14:12
951d602 to
ea46f08
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Block Store doesn't restore data
on Google APIs emulators once the app has been
uninstalled or had its data cleared.
This should allow testing in debug without going through the tedious process of: