Repository navigation
build: stop compiling libopus, and drop cmake from the image - #285
Merged
Merged
Conversation
waveflow-core now keeps its libopus decoder behind an opus feature in its default set (InstaZDLL/WaveFlow#883). This server declares default-features = false and decodes through FFmpeg, so moving the pin removes opusic-sys and the cmake crate from the graph, and the builder stage no longer installs cmake. The pin also brings what landed on WaveFlow's main since bd8d360, which adds realfft for its rhythm analysis; lofty does not move. Closes #282 Signed-off-by: InstaZDLL <github.105mh@8shield.net>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #282.
waveflow-corenow keeps its libopus decoder behind anopusfeature in its default set (InstaZDLL/WaveFlow#883). This server already declaresdefault-features = falseand decodes everything through FFmpeg, so:bd8d360to9b50f3de(the merge of #883).cargo update -p waveflow-coreremovesopusic-sysand thecmakecrate from the graph.cmake; the comment says why it is absent.The pin also brings what landed on WaveFlow's
mainin between. In the graph that isrealfft/rustfftand their small dependencies, added for the desktop's rhythm analysis.loftydoes not move, so the scanner's tag types stay on one version.How I tested
cargo tree -i opusic-sysandcargo tree -e build -i cmake: no match.cargo clippy --all-targets --all-features -D warningsand the wholecargo test --all-features: green.cargo metadata --locked: the lockfile records the new revision.release.ymlat a tag. Nothing left in the graph has a build script asking for cmake, but the first proof of the Dockerfile change will be the next release build, or a manualdocker build ..Cargo.lockstill names the old revision. It does not: the committed lock carriesrev=9b50f3de…, and--lockedresolves.Summary by CodeRabbit