Repository navigation
Stop PR comments from cancelling the Claude review (dev mirror) - #211
Merged
Merged
Conversation
Workflow-level concurrency is evaluated before the job's if, so every comment on a PR joined claude-review-<N> and cancelled the running review. Claude's own summary comment did this at the end of every review, so each run on #202 and #207 ended as cancelled (red) even though its comments were posted. A human comment mid-review would kill it outright. Comments that are not '@claude review' now get a per-run group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every Claude review run ends as cancelled (red ✗), even when it posted its full review: #207 (run 36825421844, both attempts) and #202 (run 36720540789).
Annotation: "Canceling since a higher priority waiting request for claude-review-207 exists".
concurrencyis set at workflow level, and GitHub evaluates it before the jobif:. So every comment on a PR starts a run inclaude-review-<N>and cancels the active review. That run's own job is then skipped. The last thing a review does is post its summary withgh pr comment, so each review cancels itself 2–4 s later:A human comment during the 3–4 min review would also kill it mid-run.
Change
Comments that don't start with
@claude reviewgo into a per-run group (claude-review-<N>-<run_id>), so they can't cancel anything. PR open/reopen/ready events and@claude reviewkeep the shared per-PR group, so a new review request still replaces a running one.Rollout
The action only runs when the PR's
claude-review.ymlis byte-identical to main's. This change goes in twice, with the identical file:patch→ main andci/claude-review-concurrency-dev→ dev. Neither PR will get a real review run before the main one is merged.Checks
@claude reviewon a PR should end success. The summary comment's run should be skipped in its own group, and a plain comment mid-review should leave the review running.🤖 Generated with Claude Code