chore(catalog): add version field to release-2.2 modules - #60
Merged
Conversation
Forge's blueprint schema (BlueprintModuleDisplayMetadata.version) requires a version string on every entry in official_modules[]. Without it, the 8 auto-generated transition blueprints in release/2.2 sync as validation_state=invalid and can't be imported. Each version mirrors the module's own module.version (sourced from its bnkforge.pack.json where present, falling back to module.json). state:legacy entries are intentionally skipped — they haven't migrated to module-metadata/v2alpha1 yet and don't have version-bearing packs. Co-Authored-By: Claude <noreply@anthropic.com>
4 tasks
JLCode-tech
added a commit
that referenced
this pull request
May 13, 2026
…GRATION.md (#61) * feat(shared-layer): scope bnk-forge-modules to cloud-agnostic k8s prereqs Combines stages 1 and 2 of the migration to a per-cloud blueprint repo architecture (see MIGRATION.md): - Create k8s/bnk-prerequisites/bnkforge.pack.json (v2alpha1 schema). This was the only "active" shared module missing a pack JSON; the PR #60 catalog-version fix had to source its version from module.json as a fallback. Now sourced from the pack directly. - Add k8s/bnk-cert-issuer to release-2.2-official.json. The module has a working pack and is silently depended on by cert-manager, network-setup, and bnk-prerequisites — but wasn't listed in the catalog, so Forge never generated a transition blueprint for it. Adding it as an active first-class entry. - Add MIGRATION.md at the repo root. Documents the target architecture (per-cloud repos modelled on jgruberf5/bnk-forge-ibm-roks-cluster), what stays here (shared cloud-agnostic k8s layer), what moves out (FLO, CNEInstance, network-setup vendor per-cloud), what retires (bnk-namespaces, far-setup, bnk-gateway-ext), and the phased plan. - Bump VERSION to 2.2-rev.29. Co-Authored-By: Claude <noreply@anthropic.com> * fix(bnk-prerequisites): use 'user' source for cne_pull_secret (CI) Validator allows source in {user, module, auto} only. project_secret isn't a valid value — sensitive secrets use source=user + sensitive=true, and Forge lets the deploy form bind it to a project secret. Bump VERSION to 2.2-rev.30. * fix(bnk-cert-issuer): add module.json + per-entry engine override bnk-cert-issuer is a pure-manifest module (no .tf code) rendered by the backend Python engine. The release validator previously required every active entry to match the release-level execution_engine (opentofu), which would have forced a misleading engine value on this module. Changes: - scripts/validate_module_metadata.py: allow per-entry execution.engine override; falls back to release.execution_engine when entry doesn't specify one. Backwards compatible for all 24 existing packs. - catalog/releases/release-2.2-official.json: declare execution.engine = kubernetes on the bnk-cert-issuer entry. - k8s/bnk-cert-issuer/module.json: new file, mirrors the existing pack with engine=kubernetes / deploy_models=[kubernetes_manifest]. - VERSION: 2.2-rev.30 -> 2.2-rev.31. Both pack and release-manifest validators pass locally. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the required
versionfield to every non-legacy entry incatalog/releases/release-2.2-official.jsonso the 8 auto-generated transition blueprints validate against Forge'sBlueprintModuleDisplayMetadataschema and become importable.modules[*].version(Pydanticstr, no default) — missing today, so all 8 release-2.2 blueprints sync asvalidation_state = invalid.module.versionfrom the module's ownbnkforge.pack.json(ormodule.jsonwhere the pack doesn't exist yet).state: legacyentries (bnk-vlans,bnk-gateway-ext,gateway,routes,bnk-netpolicy,bnk-secpolicy) are intentionally skipped — they haven't migrated tomodule-metadata/v2alpha1and don't have version-bearing packs yet.Modules touched
Test plan
release/2.2bnk-forge-modulesbnk-gatewayclass,cneinstance,far-setup,flo,bnk-namespaces,bnk-prerequisites,cert-manager,network-setup) flip tovalidation_state = validFollow-ups
k8s/bnk-prerequisites,bnk/far-setup) currently lack abnkforge.pack.json— version sourced frommodule.jsoninstead. Consider creating proper pack JSONs in a separate PR.bnk/*modules (vlans, gateway, routes, netpolicy, secpolicy, gateway-ext) still need migration tomodule-metadata/v2alpha1before they can be added to the manifest.🤖 Generated with Claude Code