Repository navigation
fix: accept documented profiling options in toolbar config - #70
Merged
Merged
Conversation
JacobCoffee
enabled auto-merge (squash)
October 11, 2026 02:22
Contributor
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration guide lists
profiler_backend,profiler_top_functions,profiler_sort_by,profiler_tachyon_interval_usecandenable_flamegraph, but the config classes didn't declare them. Passing any of them, e.g.LitestarDebugToolbarConfig(profiler_backend="tachyon"), raisedTypeError: unexpected keyword argument, so the new Tachyon backend could not be turned on the documented way.The five options are now config fields, with the same defaults the Profiling panel already used, so nothing changes unless you set them.
Verified: a new test builds each real config class (base, Litestar, Starlette, FastAPI) with these options and checks the panel uses them; it fails on main and passes here. Existing tests used a mock config that accepted any attribute, which is why this wasn't caught. On Python 3.15,
LitestarDebugToolbarConfig(profiler_backend="tachyon")now selects Tachyon.