fix(rrm): replace AppendToGlobalBuffer with RecordStagingCopy in UploadBuffer - #777
Merged
Merged
Conversation
…adBuffer (closes #770) AppendToGlobalBuffer uses RecordGlobalBufferCopy which only transitions to SHADER_READ — missing VERTEX_ATTRIBUTE_READ and INDEX_READ. Generic device-local buffers (bone matrices, particle VBs) need the full barrier that RecordStagingCopy provides. The staging buffer is now tracked in m_batch_frames for proper retirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #770
What
UploadBufferwas callingAppendToGlobalBuffer(buf, ...)which routes throughRecordGlobalBufferCopy. That function only hasSHADER_READin the barrier access mask — it is designed for mesh geometry that is accessed exclusively as an SSBO viagl_BaseVertexindexing. Generic device-local buffers (bone matrices, particle vertex buffers) needVERTEX_ATTRIBUTE_READandINDEX_READas well, whichRecordStagingCopyprovides.Fix
Replace the
AppendToGlobalBuffercall with the same explicit staging path thatUpdateBuffer's device-local branch uses:vmaCopyMemoryToAllocationvkCmdCopyBuffer+ full barrier viaRecordStagingCopym_batch_framesfor retirementThe standalone destination buffer (
buf) is already allocated and stored correctly. Only the upload path changes.Test plan
UploadBufferexist yet — first real caller isSkinningUploadSystem(Sprint 7)