Repository navigation
fix(deps): revert typescript to 6.x so react-scanner loads - #802
Merged
Merged
Conversation
typescript@7 ships only a launcher for the native Go compiler. Its "." export resolves to lib/version.cjs, which has no SyntaxKind. react-scanner loads @typescript-eslint/typescript-estree, which needs the JavaScript TypeScript API. estree hoists to the repo root, so it resolved the root typescript@7 instead of react-scanner's nested 5.6.2 and crashed with "Cannot read properties of undefined (reading 'BarBarToken')". The build stayed green, so npm start only failed at `node build/run.js`. Reverts #742. Dependabot now ignores typescript majors, otherwise the daily bot reopens the same bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Reverts the
typescript6 → 7 bump from #742, which leftnpm startdead.What is wrong. TypeScript 7's npm package is only a launcher for the native Go compiler. Its
"."export resolves tolib/version.cjs, which has noSyntaxKind.src/index.tsimportsreact-scanner, which loads@typescript-eslint/typescript-estree, which needs the JavaScript TypeScript API. react-scanner pinstypescript@5.6.2and npm nests it correctly, buttypescript-estreehoists to the repo root and so resolvedtypescript@7instead:The result is
TypeError: Cannot read properties of undefined (reading 'BarBarToken').tscitself still compiled, and no test importsreact-scanner, so CI stayed green through the bump. The tool has been broken onmainat runtime since #742 merged. npm prints a header only for named scripts, so the crash reads as a build failure when it actually comes fromnode build/run.js.