Repository navigation
Drop the test for atomics on local memory - #3408
Merged
Merged
Conversation
The test predates leaving atomic validation to GPUCompiler, when it checked the address space assertion in CUDA.jl's atomic functions. It now only exercises a GPUCompiler rule, and that rule changed: GPUCompiler 2.15 lowers atomics on local memory to plain accesses instead of rejecting them (JuliaGPU/GPUCompiler.jl#963), so the test fails there. GPUCompiler tests its own validation, and the atomics tests here already check that CUDA.jl surfaces those errors.
Contributor
CUDA.jl BenchmarksDetails
This comment was automatically generated by workflow using github-action-benchmark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUCompiler 2.15 (JuliaGPU/GPUCompiler.jl#963) lowers atomics on local memory to plain loads and stores instead of rejecting them, so the
atomic operation in address space 5test intest/core/device/intrinsics.jlnow fails. It breaks GPUCompiler's downstream CUDA.jl job on main and on every PR.The test dates from when CUDA.jl's atomic functions asserted the address space themselves. Since #3350 it only re-checks a GPUCompiler rule, which GPUCompiler covers in its own tests. The atomics testset (
test/core/device/intrinsics/atomics.jl) already checks that GPUCompiler's atomic validation errors surface through CUDA.jl, with a backtrace into the kernel, for every atomic function and for UnsafeAtomics. So this removes the test rather than moving it to another invalid address space. Removing it works across the wholeGPUCompiler = "2.13"compat range.